Unless you are planning to upgrade to the larger size XS Max it's probably not worth it if you have the iPhone X, but previous generation phones will make a bigger difference.
The biggest benefit the new phone has is the size. I have really enjoyed the larger size iPhones and the XS Max seems like the perfect sized phone. The gorgeous 6.5-inch screen is amazing. Plus the longer battery life really helps. In fact, now I rarely see under 50% when only charging at night and the little bit that CarPlay adds something that the plus-sized phones didn't offer even though they were rated for a similar battery life. The new speakers are incredible. It's unbelievable the difference they made. You are actually surprised it's coming from a phone and it just feels less tinny.